Skip to content

Simple file dialog: allow editing folder name on create-folder prompt #320390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −15
Draft

Simple file dialog: allow editing folder name on create-folder prompt #320390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90afe29
Initial plan
Copilot Jun 8, 2026
26ef550
Simple file dialog: allow editing folder name when prompted to create
Copilot Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 29 additions & 15 deletions src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ export class SimpleFileDialog extends Disposable implements ISimpleFileDialog {
return ((path.length > 1) && this.endsWithSlash(path)) ? path.substr(0, path.length - 1) : path;
}

private yesNoPrompt(uri: URI, message: string): Promise<boolean> {
private yesNoPrompt(uri: URI, message: string, allowEdit: boolean = false): Promise<URI | undefined> {
interface YesNoItem extends IQuickPickItem {
value: boolean;
}
Expand All @@ -902,24 +902,31 @@ export class SimpleFileDialog extends Disposable implements ISimpleFileDialog {
prompt.customButtonSecondary = true;
prompt.value = this.pathFromUri(uri);

let isResolving = false;
return new Promise<boolean>(resolve => {
let resolvedUri: URI | undefined;
return new Promise<URI | undefined>(resolve => {
disposableStore.add(prompt.onDidAccept(() => {
isResolving = true;
resolvedUri = this.remoteUriFrom(prompt.value.trimRight(), uri);
prompt.hide();
resolve(true);
resolve(resolvedUri);
}));
disposableStore.add(prompt.onDidHide(() => {
if (!isResolving) {
resolve(false);
if (resolvedUri === undefined) {
// If the user typed a different value but did not accept,
// preserve their edits in the file picker so they don't have to retype.
if (allowEdit && prompt.value !== this.pathFromUri(uri)) {
this.filePickBox.value = prompt.value;
}
resolve(undefined);
}
this.filePickBox.show();
this.hidden = false;
disposableStore.dispose();
}));
disposableStore.add(prompt.onDidChangeValue(() => {
prompt.hide();
}));
if (!allowEdit) {
disposableStore.add(prompt.onDidChangeValue(() => {
prompt.hide();
}));
}
disposableStore.add(prompt.onDidCustom(() => {
prompt.hide();
}));
Expand Down Expand Up @@ -951,15 +958,15 @@ export class SimpleFileDialog extends Disposable implements ISimpleFileDialog {
// Replacing a file.
// Show a yes/no prompt
const message = nls.localize('remoteFileDialog.validateExisting', '{0} already exists. Are you sure you want to overwrite it?', resources.basename(uri));
return this.yesNoPrompt(uri, message);
return !!(await this.yesNoPrompt(uri, message));
} else if (!(isValidBasename(resources.basename(uri), this.isWindows))) {
// Filename not allowed
this.filePickBox.validationMessage = nls.localize('remoteFileDialog.validateBadFilename', 'Please enter a valid file name.');
return false;
} else if (!statDirname) {
// Folder to save in doesn't exist
const message = nls.localize('remoteFileDialog.validateCreateDirectory', 'The folder {0} does not exist. Would you like to create it?', resources.basename(resources.dirname(uri)));
return this.yesNoPrompt(uri, message);
return !!(await this.yesNoPrompt(uri, message));
} else if (!statDirname.isDirectory) {
this.filePickBox.validationMessage = nls.localize('remoteFileDialog.validateNonexistentDir', 'Please enter a path that exists.');
return false;
Expand All @@ -974,12 +981,19 @@ export class SimpleFileDialog extends Disposable implements ISimpleFileDialog {
&& statDirname?.isDirectory && !statDirname.readonly
&& isValidBasename(resources.basename(uri), this.isWindows)) {
const message = nls.localize('remoteFileDialog.validateCreateDirectoryOpen', 'The folder {0} does not exist. Would you like to create it?', resources.basename(uri));
const shouldCreate = await this.yesNoPrompt(uri, message);
if (!shouldCreate) {
const folderUri = await this.yesNoPrompt(uri, message, true);
if (!folderUri) {
return false;
}
// If the user edited the path in the prompt, propagate the new value
// back to the file picker and let validation run again on the new path
// rather than creating a folder at the edited path immediately.
if (!resources.isEqual(folderUri, uri)) {
this.filePickBox.value = this.pathFromUri(folderUri);
return false;
}
try {
await this.fileService.createFolder(uri);
await this.fileService.createFolder(folderUri);
return true;
} catch (e) {
this.filePickBox.validationMessage = nls.localize('remoteFileDialog.createFolderFailed', 'Could not create folder: {0}', e.message);
Expand Down