Reinstate colors of symbol codicons when used in custom tree views#320391
Open
gjsjohnmurray wants to merge 1 commit into
Open
Reinstate colors of symbol codicons when used in custom tree views#320391gjsjohnmurray wants to merge 1 commit into
gjsjohnmurray wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates tree view icon rendering so theme icons without an explicit color get a fallback CSS class applied.
Changes:
- Add
codicon-coloredclass whennode.themeIconhas nocolorconfigured.
Comment on lines
1474
to
1477
| templateData.icon.style.color = this.themeService.getColorTheme().getColor(node.themeIcon.color.id)?.toString() ?? ''; | ||
| } else { | ||
| iconClass = iconClass + ' codicon-colored'; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This issue appears to predate this PR
Contributor
Author
|
Validated using the extension-samples branch documented at #299479 (comment) 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #299479
Issue was caused by #267787