Skip to content

[cherry-pick] sessions: surface archived state in session header#320440

Merged
sandy081 merged 1 commit into
release/1.124from
cherry-pick/320392
Jun 8, 2026
Merged

[cherry-pick] sessions: surface archived state in session header#320440
sandy081 merged 1 commit into
release/1.124from
cherry-pick/320392

Conversation

@vs-code-engineering

Copy link
Copy Markdown
Contributor

Cherry-pick of #320392 from main.

What

In the Agents window, an archived ("done") session is currently almost invisible — the only signals are missing actions and the Restore button hidden away in the title bar's command center.

This PR consolidates the archived-session UI on the session header:

  • Distinct "done" glyph in the status icon. getStatusIcon now returns Codicon.passFilled (in the muted read-indicator color) for archived sessions, instead of reusing the plain read dot. Applies wherever the shared status icon is used (header, sessions list, picker).
  • Restore action moved to the session header toolbar. Previously contributed to Menus.CommandCenter (title bar pill area); now contributed to Menus.SessionBarToolbar, navigation group (order 5), so it sits where New Chat would otherwise be. Gated by the session-scoped SessionIsArchivedContext, which is the right scope for a per-session header toolbar.
  • Hide New Chat and Pin/Unpin in the header when archived. These actions don't apply to a done session — SessionIsArchivedContext.negate() added to both when clauses.

Why

A done session now reads as done at a glance (check glyph in the header), and the Restore affordance lives next to the session it acts on, rather than across the window in the title bar. The header toolbar stays focused on actions that are actually meaningful for the current state.

Notes for reviewers

  • No new menu IDs or context keys — reuses the existing per-session SessionIsArchivedContext already bound in sessionView.ts (and used elsewhere for header context-menu gating).
  • The Restore action still appears in the sessions-list per-item toolbar and the list item context menu (unchanged); only the title-bar command-center contribution moved.
  • Title text is intentionally not dimmed — the glyph + hidden-actions combination conveys the state without changing typography.
  • Type-check (compile-check-ts-native) and layers check both pass.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Copilot AI review requested due to automatic review settings June 8, 2026 16:28
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Jun 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vs-code-engineering

Copy link
Copy Markdown
Contributor Author

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@sandy081

Matched files:

  • src/vs/sessions/services/sessions/browser/sessionsListModelService.ts

@lszomoru

Matched files:

  • src/vs/sessions/services/sessions/browser/sessionsListModelService.ts

@sandy081 sandy081 enabled auto-merge (squash) June 8, 2026 18:13
@sandy081 sandy081 closed this Jun 8, 2026
auto-merge was automatically disabled June 8, 2026 18:14

Pull request was closed

@sandy081 sandy081 reopened this Jun 8, 2026
@sandy081 sandy081 merged commit b405704 into release/1.124 Jun 8, 2026
43 of 47 checks passed
@sandy081 sandy081 deleted the cherry-pick/320392 branch June 8, 2026 18:54
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants