Skip to content

Hide microphone picker box when only one microphone is present - #328766

Draft
meganrogge with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-single-microphone-issue
Draft

Hide microphone picker box when only one microphone is present#328766
meganrogge with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-single-microphone-issue

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

With a single normalized microphone, the dictation and voice-mode onboarding cards showed an empty bordered box instead of nothing.

The picker row is hidden by setting pickerContainer.hidden = true, but the picker's CSS class declares display: flex. A class selector outweighs the UA [hidden] { display: none } rule, so the element kept rendering its border/background/fixed height as an empty box.

  • dictationOnboarding.css / voiceModeOnboarding.css — add a .picker[hidden] { display: none } override so the hidden attribute actually hides the row (both cards shared the same latent bug).
  • dictationOnboarding.test.ts — regression test asserting the single-microphone case fully omits the picker: hidden, no select, no mic name text, waveform still present.
.dictation-onboarding-picker[hidden] {
	display: none;
}

Copilot AI requested review from Copilot and removed request for Copilot August 3, 2026 17:37
Copilot AI linked an issue Aug 3, 2026 that may be closed by this pull request
@meganrogge meganrogge added this to the 1.132.0 milestone Aug 3, 2026
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot August 3, 2026 17:49
Copilot AI changed the title [WIP] Fix blank select box for single microphone Hide microphone picker box when only one microphone is present Aug 3, 2026
Copilot AI requested a review from meganrogge August 3, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single microphone results in blank box

2 participants