Skip to content

Fix keyboard activation of the voice input mode microphone button #328768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −0
Draft

Fix keyboard activation of the voice input mode microphone button #328768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8351cd
Initial plan
Copilot Aug 3, 2026
065012a
Enable keyboard activation (Enter/Space) for segmented voice/dictatio…
Copilot Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/vs/workbench/contrib/chat/browser/voiceInputMode/voiceInputModeActionViewItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ export class VoiceInputModeActionViewItem extends BaseActionViewItem {
dom.EventHelper.stop(e, true);
this._onClickDictation();
}));
this._registerActivationKeys(this._dictationCell, () => this._onClickDictation());
this._register(addMicButtonContextMenuListener(
this._dictationCell,
() => getDictationContextMenuActions(this.commandService, this.configurationService, this.keybindingService, DICTATION_TOGGLE_COMMAND_ID),
Expand Down Expand Up @@ -419,6 +420,7 @@ export class VoiceInputModeActionViewItem extends BaseActionViewItem {
dom.EventHelper.stop(e, true);
this._onClickVoicePowerToggle();
}));
this._registerActivationKeys(this._voiceCell, () => this._onClickVoicePowerToggle());
this._register(addMicButtonContextMenuListener(
this._voiceCell,
() => getVoiceModeContextMenuActions(this.commandService, this.configurationService, this.keybindingService, VOICE_START_COMMAND_ID),
Expand Down Expand Up @@ -467,6 +469,7 @@ export class VoiceInputModeActionViewItem extends BaseActionViewItem {
}
this._onClickListen();
}));
this._registerActivationKeys(this._listenCell, () => this._onClickListen());

// Dictation activity: driven directly by the built-in on-device speech-to-text
// service so the mic reliably fills while a dictation session is recording or
Expand Down Expand Up @@ -694,6 +697,23 @@ export class VoiceInputModeActionViewItem extends BaseActionViewItem {
}
}

/**
* Activate a segmented cell from the keyboard. The cells live inside a toolbar's
* `ActionBar`, whose key handler runs the (no-op) placeholder action on Enter/Space
* and calls `preventDefault`/`stopPropagation`, which would otherwise swallow the
* native button activation. Handle Enter/Space here and stop the event before it
* bubbles to the ActionBar so the focused cell's own gesture runs.
*/
private _registerActivationKeys(cell: HTMLElement, handler: () => void): void {
this._register(dom.addStandardDisposableListener(cell, dom.EventType.KEY_DOWN, e => {
if (e.equals(KeyCode.Enter) || e.equals(KeyCode.Space)) {
e.preventDefault();
e.stopPropagation();
handler();
}
}));
}

private _onClickDictation(): void {
this.voiceInputModeService.setSelectedMode('dictation');

Expand Down