Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/vs/platform/agentHost/node/agentHostTelemetryReporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ export interface IAgentHostToolInvokedReport {
toolSourceKind: string;
result: ToolInvokedResult;
invocationTimeMs?: number;
resultSizeInCharacters: number;
}

export interface IAgentHostAskQuestionsToolInvokedEvent {
Expand Down Expand Up @@ -811,6 +812,7 @@ export class AgentHostTelemetryReporter {
toolSourceKind: report.toolSourceKind,
invocationTimeMs: report.invocationTimeMs,
provider: report.provider,
resultSizeInCharacters: report.resultSizeInCharacters,
});
}

Expand Down
2 changes: 2 additions & 0 deletions src/vs/platform/agentHost/node/agentHostToolCallTracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ export class AgentHostToolCallTracker extends Disposable {
this._toolCalls.delete(key);
const resultBucket = deriveToolInvokedResult(result);
const totalTimeMs = timing.lifecycleStopWatch.elapsed();
const resultSizeInCharacters = JSON.stringify(result).length;

this._reporter.toolInvoked({
provider: timing.provider,
Expand All @@ -151,6 +152,7 @@ export class AgentHostToolCallTracker extends Disposable {
toolSourceKind: timing.toolSourceKind,
result: resultBucket,
invocationTimeMs: timing.invocationStopWatch?.elapsed(),
resultSizeInCharacters,
});

const stalled = this._stalledToolCalls.get(key);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { ITelemetryService, TelemetryLevel } from '../../../telemetry/common/tel
import { AgentSession, IAgent } from '../../common/agentService.js';
import { SessionInputRequestKind } from '../../common/state/protocol/state.js';
import { ActionType, type ChatAction } from '../../common/state/sessionActions.js';
import { buildDefaultChatUri, MessageKind, SessionStatus, ToolCallConfirmationReason, ToolCallContributorKind, ToolCallStatus, type ToolCallContributor, type ToolCallResult } from '../../common/state/sessionState.js';
import { buildDefaultChatUri, MessageKind, SessionStatus, ToolCallConfirmationReason, ToolCallContributorKind, ToolCallStatus, ToolResultContentType, type ToolCallContributor, type ToolCallResult } from '../../common/state/sessionState.js';
import { IAgentHostCheckpointService, NULL_CHECKPOINT_SERVICE } from '../../common/agentHostCheckpointService.js';
import { IAgentHostTerminalManager } from '../../node/agentHostTerminalManager.js';
import { AgentHostLocalTurns } from '../../node/agentHostLocalTurns.js';
Expand Down Expand Up @@ -235,6 +235,7 @@ suite('AgentSideEffects — tool call telemetry', () => {
toolSourceKind: 'agentHost',
provider: 'mock',
invocationTimeMs: true,
resultSizeInCharacters: 41,
},
}]);
});
Expand All @@ -256,6 +257,7 @@ suite('AgentSideEffects — tool call telemetry', () => {
toolSourceKind: 'mcp',
provider: 'mock',
invocationTimeMs: undefined,
resultSizeInCharacters: 90,
},
}]);
});
Expand Down Expand Up @@ -284,10 +286,25 @@ suite('AgentSideEffects — tool call telemetry', () => {
toolSourceKind: 'client',
provider: 'mock',
invocationTimeMs: true,
resultSizeInCharacters: 47,
},
}]);
});

test('includes result content in the serialized result size', () => {
setupSession();
startTurn('turn-1');

toolStart('turn-1', 'tc-read', 'read_file');
toolComplete('turn-1', 'tc-read', {
success: true,
pastTenseMessage: 'read files',
content: [{ type: ToolResultContentType.Text, text: 'alpha\nbeta' }],
});

assert.deepStrictEqual(toolEvents()[0].data.resultSizeInCharacters, 97);
});

test('only accepts contributor refinements that preserve execution ownership', async () => {
setupSession();
startTurn('turn-1');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ export type LanguageModelToolInvokedEvent = LanguageModelToolTelemetryData & {
prepareTimeMs?: number;
invocationTimeMs?: number;
provider?: string;
resultSizeInCharacters?: number;
};

export type LanguageModelToolInvokedClassification = LanguageModelToolTelemetryClassification & {
result: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether invoking the LanguageModelTool resulted in an error.' };
prepareTimeMs?: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Time spent in prepareToolInvocation method in milliseconds.' };
invocationTimeMs?: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Time spent in tool invoke method in milliseconds.' };
provider?: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The agent host provider that invoked the tool (e.g. copilotcli, claude, codex), if applicable.' };
resultSizeInCharacters?: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; isMeasurement: true; comment: 'Length of the serialized Agent Host tool result in UTF-16 code units, if applicable.' };
owner: 'roblourens';
comment: 'Provides insight into the usage of language model tools.';
};
Loading