Enhance Mac keyboard mapping with layout-dependent accelerators - #328867
Draft
sbatten wants to merge 1 commit into
Draft
Enhance Mac keyboard mapping with layout-dependent accelerators#328867sbatten wants to merge 1 commit into
sbatten wants to merge 1 commit into
Conversation
…accelerators and update test cases
Contributor
There was a problem hiding this comment.
Pull request overview
Adds native macOS menu accelerators for layout-dependent keys, fixing misaligned shortcut labels.
Changes:
- Derives safe Electron accelerators from printable layout characters.
- Handles dead keys, shifted symbols, and named characters.
- Updates focused tests and mapping snapshots.
Show a summary per file
| File | Description |
|---|---|
macLinuxKeyboardMapper.ts |
Generates safe macOS accelerators for unstable scan codes. |
macLinuxKeyboardMapper.test.ts |
Tests supported and rejected accelerator characters. |
mac_de_ch.txt |
Updates Swiss German mapping expectations. |
mac_zh_hant2.txt |
Updates Traditional Chinese mapping expectations. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #328194
Improve keyboard mapping for Mac by adding layout-dependent accelerators and updating related test cases. This enhancement ensures better compatibility with various keyboard layouts.