sessions: group multi-root sessions by workspace - #328876
Open
DonJayamanne wants to merge 4 commits into
Open
Conversation
Use workspace-file provenance as the stable section identity and display the recorded workspace name without changing operational workspace badges. Hide the unsupported new-session action for multi-root sections. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Groups multi-root Agent Host sessions by workspace-file provenance while preserving operational workspace behavior.
Changes:
- Exposes multi-root workspace provenance on sessions.
- Adds stable workspace grouping, labels, and ordering identities.
- Hides unsupported multi-root session creation actions and adds tests.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/SESSIONS.md |
Documents workspace provenance. |
src/vs/sessions/SESSIONS_LIST.md |
Documents grouping and ordering behavior. |
src/vs/sessions/services/sessions/common/session.ts |
Adds multi-root session metadata. |
src/vs/sessions/services/sessions/browser/sessionSectionOrderService.ts |
Updates identity documentation. |
src/vs/sessions/contrib/sessions/test/browser/sessionsViewActions.test.ts |
Tests action visibility. |
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts |
Tests multi-root grouping and labels. |
src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts |
Gates workspace creation actions. |
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts |
Implements multi-root sections. |
src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts |
Tests provenance updates. |
src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts |
Publishes provenance from metadata. |
src/vs/sessions/contrib/providers/agentHost/AGENT_HOST_SESSIONS_PROVIDER.md |
Documents provider behavior. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
Use the registered filesystem provider's casing rules for multi-root section identities and preserve provenance through visible-session wrappers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Suffix multi-root workspace section names with a localized Workspace label. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DonJayamanne
marked this pull request as ready for review
August 4, 2026 07:00
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @sandy081Matched files:
@lszomoruMatched files:
|
justschen
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.code-workspacefilename fallback+action because the Agents Window cannot create multi-root sessionsValidation
npm run transpile-clientsessionsList,sessionsViewActions, and Agent Host provider unit testsnpm run valid-layers-checknpm run precommitnpm run typecheck-clientremains blocked by an unchanged Zod/IJsonSchema mismatch insrc/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:899on currentmain.