Automations view polish - #328883
Merged
Merged
Conversation
Previously the bottom border on the custom view header band was transparent by default and only became visible when the user scrolled down (via the .scrolled class toggled in customViewNode.ts). This meant the divider between the header and content was invisible at the top scroll position. Change the border color to always be visible so the header is consistently separated from the content regardless of scroll position. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The automation dialog CSS was still living in aiCustomizationManagement.css after the automations list widget was removed in #328654. Move it to a dedicated automationDialog.css file next to the dialog service and add the import there. Also fix padding issues where Create/Cancel buttons and the close button were too close to the dialog border (padding: 0 was inherited from the base dialog override): - dialog-toolbar-row (close button): 4px/6px → 8px/10px from top/right - dialog-buttons-row: add 8px top, 10px side, 10px bottom padding Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Schedule, Time, Day of week, and Prompt labels were rendered as <label> elements without 'for' attributes. Chromium applies cursor: pointer to <label> elements regardless of author CSS, making them look like links. Change them to <span> elements since they are purely visual section headers with no programmatic association to their controls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chat.css sets padding: 4px 0 on .interactive-input-part, designed for the full chat panel. In the compact dialog this adds visible dead space above the rounded input container (below the Prompt label) and below the secondary toolbar. Zero out both ends. Also reduce the 6px bottom padding inside .chat-input-container (between the picker chips and the container border) to 2px. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
word-break: break-word on the card name container caused the Disabled badge to word-wrap when titles were long. Replace with ellipsis truncation on the title text so the badge always stays on one line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
widget.border is transparent in many themes, making cards invisible. Switch to editorWidget.border which has concrete defaults across light and dark themes, and add a contrastBorder override for HC themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Polishes the Automations view and dialog styling, action visibility, and form presentation.
Changes:
- Makes “New Automation” visibility react to global automation state.
- Relocates and refines dialog styling.
- Improves card borders, title truncation, and header separation.
Show a summary per file
| File | Description |
|---|---|
aiCustomizationManagement.css |
Removes relocated dialog styles. |
automationsView.ts |
Adds global item-state tracking and menu gating. |
automationsCards.css |
Updates card borders and title truncation. |
automationDialog.css |
Hosts and refines dialog styles. |
automationDialogService.ts |
Imports the dedicated stylesheet. |
automationDialog.ts |
Replaces form labels with spans. |
contextkeys.ts |
Defines the automation-items context key. |
customViewGridPart.css |
Makes the header divider persistent. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 2
- Review effort level: Balanced
Contributor
Screenshot ChangesBase: Changed (6)
|
| Before | After |
|---|---|
 |
 |
sessions/customViewNode/CustomViewNodeTitleOnly/Light
| Before | After |
|---|---|
 |
 |
sessions/customViewNode/CustomViewNodeWithDescription/Dark
| Before | After |
|---|---|
 |
 |
sessions/customViewNode/CustomViewNodeWithDescription/Light
| Before | After |
|---|---|
 |
 |
sessions/customViewNode/CustomViewNodeNarrowMaxWidth/Dark
| Before | After |
|---|---|
 |
 |
sessions/customViewNode/CustomViewNodeNarrowMaxWidth/Light
| Before | After |
|---|---|
 |
 |
Added (6)
sessions/automations/automationsView/Populated/Dark
sessions/automations/automationsView/Populated/Light
sessions/automations/automationsView/Empty/Dark
sessions/automations/automationsView/Empty/Light
sessions/automations/automationsView/Narrow/Dark
sessions/automations/automationsView/Narrow/Light
… test The title span needs flex: 1 1 0; min-width: 0 to actually shrink as a flex item — without it the min-width: auto default prevents ellipsis from engaging on long unbroken strings. Also add test coverage for the AutomationsHasItemsContext global context key fix: verifies the key transitions false → true → false as the automations observable changes through empty/non-empty/empty states. Export AutomationsCustomViewContribution to enable direct instantiation in the test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benvillalobos
marked this pull request as ready for review
August 4, 2026 02:52
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @benibenjMatched files:
|
This reverts commit 0e363b8.
Stamp data-view-id on the custom view node element so individual views can override the scroll-driven divider behavior via CSS. Use this to always show the header bottom border in the automations view, while keeping the scroll-driven behavior intact for any other custom views. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
justschen
previously approved these changes
Aug 4, 2026
benvillalobos
enabled auto-merge (squash)
August 4, 2026 04:20
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hediet
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328741
A set of small polish fixes for the Automations custom view and dialog.
AutomationsHasItemsContextbeing set on a scoped context key service; move to the global service in the contribution so the "New Automation" button shows/hides without delayautomationDialog.cssfile (was orphaned inaiCustomizationManagement.cssafter Remove Automations section from AI Customizations editor #328654)<label>to<span>interactive-input-parttop/bottom padding) and inside the containereditorWidget.bordertoken for card outlines (waswidget.border, which is transparent in many themes); addcontrastBorderoverride for HC themes