Skip to content

Chat: make editor send button circular - #329022

Open
eli-w-king wants to merge 5 commits into
microsoft:mainfrom
eli-w-king:eli/agents/fix-editor-send-button-shape
Open

Chat: make editor send button circular#329022
eli-w-king wants to merge 5 commits into
microsoft:mainfrom
eli-w-king:eli/agents/fix-editor-send-button-shape

Conversation

@eli-w-king

Copy link
Copy Markdown
Contributor

Summary

  • make the shared Chat send button circular in editor-hosted Chat, matching the Agents window
  • preserve the primary button foreground for the enabled send icon across Chat hosts

Testing

  • verified the enabled editor Chat send button is 22×22 with a circular radius
  • verified the enabled icon uses the primary button foreground (white) on the primary button background
  • npm run transpile-client
  • hygiene checks

eli-w-king and others added 2 commits August 4, 2026 12:04
Apply the circular send control styling by its shared action class so editor-hosted chat surfaces match the Agents window.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the primary button foreground above the blanket toolbar codicon color rule after making the send styling host-independent.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 4, 2026 19:15
@eli-w-king eli-w-king self-assigned this Aug 4, 2026
@eli-w-king eli-w-king added this to the 1.133.0 milestone Aug 4, 2026
@eli-w-king
eli-w-king marked this pull request as ready for review August 4, 2026 19:18
@eli-w-king
eli-w-king enabled auto-merge August 4, 2026 19:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the shared Chat send button styling so editor-hosted Chat matches the circular Agents window control while preserving enabled-state theme colors.

Changes:

  • Broadens circular send-button sizing and focus styles across Chat hosts.
  • Preserves primary button foreground/background tokens for enabled send actions.
  • Retains compact icon alignment for send and editing-session actions.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/media/chat.css Generalizes circular send-button styling and enabled/interactive colors.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread src/vs/workbench/contrib/chat/browser/widget/media/chat.css Outdated

@meganrogge meganrogge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot comment looks valid, can we test this?

eli-w-king and others added 2 commits August 4, 2026 13:03
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants