Agent Host: Sandbox updates - #330146
Draft
Dileep Yavanmandha (dileepyavan) wants to merge 7 commits into
Draft
Conversation
Copilot started reviewing on behalf of
Dileep Yavanmandha (dileepyavan)
August 11, 2026 00:37
View session
Dileep Yavanmandha (dileepyavan)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds independently configurable Windows sandbox support for the Copilot SDK shell path and integrates it into permission pickers.
Changes:
- Adds platform-specific SDK sandbox settings and policy forwarding.
- Builds complete Windows-compatible SDK sandbox policies.
- Adds sandbox toggles and status labels to permission pickers.
Show a summary per file
| File | Description |
|---|---|
agentHostSandboxForwarder.test.ts |
Tests platform-specific policy forwarding. |
agentHostSandboxForwarder.ts |
Forwards independent SDK sandbox settings. |
permissionPickerActionItem.test.ts |
Tests sandbox-setting selection. |
agentHostChatInputPicker.test.ts |
Tests Default-item toggle eligibility. |
permissionPickerActionItem.ts |
Adds session-aware sandbox toggling. |
chatInputPart.ts |
Supplies the effective session type. |
chat.shared.contribution.ts |
Registers Windows SDK sandbox configuration. |
agentHostChatInputPicker.ts |
Adds Agent Host sandbox controls. |
sandboxConfigForSdk.test.ts |
Covers complete cross-platform policies. |
copilotAgentSession.test.ts |
Updates Windows per-request expectations. |
sandboxConfigForSdk.ts |
Builds complete SDK sandbox policies. |
agentService.ts |
Defines the Windows setting identifier. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 12/12 changed files
- Comments generated: 2
- Review effort level: Balanced
Comment on lines
+131
to
+133
| * Windows uses its platform-specific enablement and filesystem settings. It | ||
| * does not fall back to the shared enablement setting so Windows rollout is | ||
| * controlled independently. |
Comment on lines
+178
to
+181
| addCurrentWorkingDirectory: true, | ||
| allowBypass: true, | ||
| allowDevToolAccess: true, | ||
| auth: { |
Dileep Yavanmandha (dileepyavan)
marked this pull request as ready for review
August 11, 2026 01:24
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Anthony Kim (@anthonykim1)Matched files:
|
Dileep Yavanmandha (dileepyavan)
marked this pull request as draft
August 11, 2026 01:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end sandbox support for the Copilot SDK shell path, including an independently controlled Windows rollout and permission-picker integration.
chat.agentHost.sdkSandbox.enabledWindowsso Windows sandboxing can be enabled independently from macOS/LinuxallowNetworkmode to the separate network policyTesting