Fix PoliCheck non-inclusive language findings#580
Merged
Conversation
- Replace 'whitelist' with 'allowlist' in post-metrics-comment.yml - Replace 'master' with 'main' in pr-review SKILL.md - Replace 'Sanity check' with 'Validation check' in MsixService.cs - Replace 'Sanity check' with 'Precondition check' in test code Resolves SEV1 and SEV2 PoliCheck compliance findings. ADO: https://microsoft.visualstudio.com/os/_workitems/edit/62727007 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a small set of comments/docs/strings to address PoliCheck SEV1/SEV2 inclusive language findings across GitHub workflow content, PR-review skill guidance, and CLI/test wording.
Changes:
- Replaces “whitelist” terminology with “allowlist” in a workflow security-model comment.
- Updates “Sanity check” wording to “Validation check” / “Precondition check” in CLI service and tests.
- Edits the pr-review skill’s base-branch guidance to remove
masterwording (but currently introduces an internal inconsistency; see comment).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/post-metrics-comment.yml | Inclusive-language tweak in a security-model comment (“allowlist”). |
| .github/skills/pr-review/SKILL.md | Inclusive-language update to branch-name guidance (needs a functional fallback adjustment). |
| src/winapp-CLI/WinApp.Cli/Services/MsixService.cs | Renames a comment from “Sanity check” to “Validation check”. |
| src/winapp-CLI/WinApp.Cli.Tests/GetWinappPathCommandTests.cs | Updates an assertion message to “Precondition check”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The previous fix replaced origin/master with origin/main, creating a duplicate. Use origin/HEAD which resolves to whatever the remote default branch is, providing a functional fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Build Metrics ReportBinary Sizes
Test Results✅ 1198 passed, 1 skipped out of 1199 tests in 404.8s (-21.4s vs. baseline) Test Coverage❌ 17.3% line coverage, 36.3% branch coverage · ✅ no change vs. baseline CLI Startup Time43ms median (x64, Updated 2026-06-17 01:46:21 UTC · commit |
Add PoliCheck SDL scanning to CI and release pipelines via 1ES Pipeline Template sdl parameters. Configured to break on Warning severity to catch SEV1 and SEV2 inclusive language violations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nmetulev
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves SEV1 and SEV2 PoliCheck compliance findings for inclusive language.
Changes
Excluded (false positives / exceptions)
Compliance
ADO: https://microsoft.visualstudio.com/os/_workitems/edit/62727007