Adding --extern to generate extern blocks #3827
Closed
+70
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@yasster Can you share more context on what this addresses? "Windows compatibility" is pretty vague, especially for something that's already Windows compatible. (We typically close PRs that aren't preceded by an issue.) Thanks! |
Author
|
@riverar This was done to bring back support for extern blocks, Since this is needed for the windows build system (Within Windows itself) . I've talked to @kennykerr about this and how we can't now use |
Author
|
Closing this to follow this PR #3828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the feature to generate --extern blocks for Windows compatibility.