Replace WPP with TraceLogging across XDP codebase #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely migrates the XDP for Windows project from WPP (Windows Performance Preprocessor) to TraceLogging, addressing the pain points for both developers and end users mentioned in the issue.
Background
WPP, while functional, creates significant friction in the development process:
Changes Made
Core XDP Driver (
src/xdp/)inc/xdptrace.hfrom WPP macros to TraceLogging provider declarationstrace.cwith TraceLogging provider implementationxdp.vcxprojSupporting Libraries
src/rtl/): Removed WPP configuration, uses main XDP trace headersrc/xdplwf/): Removed WPP configuration and TMH includes from 11 filesTest Projects
test/xdpmp/): Converted to separate TraceLogging provider with dedicated trace.ctest/fakendis/): Converted to separate TraceLogging provider with dedicated trace.ctest/functional/inc/fntrace.h): Converted trace headertest/spinxsk/): Converted trace header, removed TMH includeArchitecture
The migration maintains a hybrid approach:
This preserves the performance characteristics of the hot path while dramatically improving the developer experience for cold path logging.
Compatibility
TraceFatal,TraceError,TraceInfo, etc.)Benefits
All WPP functionality has been successfully replaced with TraceLogging equivalents while maintaining full backward compatibility for trace consumers.
Fixes #529.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.