Replaced confirmedUserActivity with confirmedActivity across alertDetermination enum references - #10015
Open
JarbasHorst wants to merge 7 commits into
Open
Replaced confirmedUserActivity with confirmedActivity across alertDetermination enum references#10015JarbasHorst wants to merge 7 commits into
JarbasHorst wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the beta Update alert (PATCH) API topic to align the alertDetermination enum member name with the value declaration used in the security alert resource documentation.
Changes:
- Replaced the
confirmedUserActivityenum member reference withconfirmedActivityin thedeterminationproperty’s allowed-values list for the betasecurity-alert-updateAPI topic.
Contributor
|
Learn Build status updates of commit 02fe570:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (4)
api-reference/beta/api/security-alert-update.md:53
- This PR updates several
alertDeterminationreferences toconfirmedActivity, butapi-reference/v1.0/api/security-alert-update.mdstill documents the old member nameconfirmedUserActivity. If the goal is to replace the enum member name across references (per the PR title/description), that file likely needs the same update.
|determination|microsoft.graph.security.alertDetermination|Specifies the determination of the alert. The possible values are: `unknown`, `apt`, `malware`, `securityPersonnel`, `securityTesting`, `unwantedSoftware`, `other`, `multiStagedAttack`, `compromisedUser`, `phishing`, `maliciousUserActivity`, `clean`, `insufficientData`, `confirmedActivity`, `lineOfBusinessApplication`, `unknownFutureValue`.|
api-reference/v1.0/resources/security-incident.md:39
- The inline list of
alertDeterminationvalues here doesn't match the canonicalalertDetermination valuestable onsecurity-alert.mdfor v1.0 (for example, this row listscompromisedUser,clean, andinsufficientData, which aren't present in that enum table). Since the type ismicrosoft.graph.security.alertDetermination, consider linking to the enum table instead of duplicating a potentially divergent value list.
|determination|microsoft.graph.security.alertDetermination|Specifies the determination of the incident. The possible values are: `unknown`, `apt`, `malware`, `securityPersonnel`, `securityTesting`, `unwantedSoftware`, `other`, `multiStagedAttack`, `compromisedUser`, `phishing`, `maliciousUserActivity`, `clean`, `insufficientData`, `confirmedActivity`, `lineOfBusinessApplication`, `unknownFutureValue`.|
api-reference/beta/resources/security-incident.md:42
- The inline list of
alertDeterminationvalues here appears to diverge from thealertDetermination valuestable onsecurity-alert.mdfor beta (this row includescompromisedUser,clean, andinsufficientData, which aren't present in the enum table). Since the property type ismicrosoft.graph.security.alertDetermination, consider linking to the enum table to avoid documenting a mismatched set of values.
|determination|microsoft.graph.security.alertDetermination|Specifies the determination of the incident. The possible values are: `unknown`, `apt`, `malware`, `securityPersonnel`, `securityTesting`, `unwantedSoftware`, `other`, `multiStagedAttack`, `compromisedUser`, `phishing`, `maliciousUserActivity`, `clean`, `insufficientData`, `confirmedActivity`, `lineOfBusinessApplication`, `unknownFutureValue`.|
api-reference/beta/api/security-alert-update.md:53
- This request-body row duplicates the
alertDeterminationmember list inline, but the list doesn't match thealertDetermination valuestable on../resources/security-alert.md(for example, it includescleanandinsufficientData, which aren't present in that enum table). To avoid drifting value lists, consider linking to the enum table instead of repeating the members here.
|determination|microsoft.graph.security.alertDetermination|Specifies the determination of the alert. The possible values are: `unknown`, `apt`, `malware`, `securityPersonnel`, `securityTesting`, `unwantedSoftware`, `other`, `multiStagedAttack`, `compromisedUser`, `phishing`, `maliciousUserActivity`, `clean`, `insufficientData`, `confirmedActivity`, `lineOfBusinessApplication`, `unknownFutureValue`.|
Contributor
|
Learn Build status updates of commit cf36a27:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed member name to align with schema definition and value declaration: