fix(skills): hide catalog-only managed skills that aren't installed (#58)#65
Merged
Merged
Conversation
) The skills:list IPC handler appended managed skills defined in managed_skill_catalog.json but not present on disk, marking them installed: false. Since there is no in-app install action for these skills, they surfaced as permanently "Not installed"/greyed entries the user could never enable. Only return managed skills that are actually installed on disk. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #58.
The
skills:listIPC handler was appending managed skills that are defined inmanaged_skill_catalog.jsonbut not present on disk, marking theminstalled: false. Because there is no in-app install action for these skills, they surfaced in the Skills list as permanently "Not installed"/greyed entries the user could never enable.Change
desktop/src/main.ts(skills:list): removed the catalog-only append loop so only managed skills actually installed on disk are returned. Built-in and custom skills are unchanged.Testing
tsc --noEmit: 0 errorseslint src/main.ts: 0 errors (pre-existing warnings only)desktop-beautify) no longer appear in the Skills list.