Skip to content

docs: fix right sidebar sponsors#1477

Merged
dinwwwh merged 1 commit intomiddleapi:mainfrom
dinwwwh:docs/fix-right-sidebar-sponsors
Mar 16, 2026
Merged

docs: fix right sidebar sponsors#1477
dinwwwh merged 1 commit intomiddleapi:mainfrom
dinwwwh:docs/fix-right-sidebar-sponsors

Conversation

@dinwwwh
Copy link
Member

@dinwwwh dinwwwh commented Mar 16, 2026

Summary by CodeRabbit

  • New Features
    • Added a "Become a sponsor" link that appears when the sponsor list has fewer than three items.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important consistency issue by fixing a recurring typo in the codebase. The change ensures that all references to the 'right sidebar' for sponsor display are correctly spelled, improving code readability and maintainability without altering functionality.

Highlights

  • Typo Fix: Corrected a consistent typo from 'rideSidebar' to 'rightSidebar' in variable names and interface properties related to the display of sponsors in the right sidebar.
Changelog
  • apps/content/.vitepress/theme/components/AsideSponsors.vue
    • Corrected the typo 'rideSidebarSize' to 'rightSidebarSize' in computed properties for filtering sponsors.
    • Updated template bindings to use 'rightSidebarLink' instead of 'rideSidebarLink' for sponsor URLs.
  • apps/content/.vitepress/theme/composables/sponsors.ts
    • Modified the 'JSONSponsor' interface to change 'rideSidebarSize' to 'rightSidebarSize'.
    • Modified the 'JSONSponsor' interface to change 'rideSidebarLink' to 'rightSidebarLink'.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR renames sidebar sponsor property names from "ride" to "right" across two files and adds conditional rendering of a "Become a sponsor" link when fewer than 3 normal sponsors are displayed. Total 8 lines modified across the interface definition and component usage.

Changes

Cohort / File(s) Summary
Sponsor Interface Updates
apps/content/.vitepress/theme/composables/sponsors.ts
Renamed interface fields: rideSidebarSizerightSidebarSize and rideSidebarLinkrightSidebarLink.
Sponsor Component Updates
apps/content/.vitepress/theme/components/AsideSponsors.vue
Updated property references to match renamed interface fields; added conditional "Become a sponsor" link that displays when normalSponsors list contains fewer than 3 items.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 From "ride" to "right" the sponsors now align,
With sponsors fewer, a link does shine,
Property names corrected with care,
Three or less, an invitation to share! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing right sidebar sponsor-related property names and bindings throughout the component and interface.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

@dosubot dosubot bot added documentation Improvements or additions to documentation javascript Pull requests that update javascript code labels Mar 16, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo from rideSidebar to rightSidebar in sponsor-related properties. The fix is applied correctly across the component and the TypeScript interface. I've added a few suggestions to improve maintainability and robustness by avoiding magic strings and providing fallback links for sponsors.

Comment on lines +11 to +12
const normalSponsors = computed(() => sponsors.value.filter(s => s.rightSidebarSize === 'normal'))
const smallSponsors = computed(() => sponsors.value.filter(s => s.rightSidebarSize === 'small'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using string literals like 'normal' and 'small' for filtering can be error-prone and harder to maintain. Consider defining these values as constants or an enum in composables/sponsors.ts alongside the JSONSponsor interface and importing them here. This improves type safety and makes future changes easier.


<div class="aside-sponsors-list">
<a v-for="sponsor in normalSponsors" :key="sponsor.login" class="aside-sponsor" target="_blank" :href="sponsor.rideSidebarLink">
<a v-for="sponsor in normalSponsors" :key="sponsor.login" class="aside-sponsor" target="_blank" :href="sponsor.rightSidebarLink">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The rightSidebarLink property is optional. If it's missing, this <a> tag will not be a functional link. To provide a fallback, consider using the optional link property from the JSONSponsor interface as well.

      <a v-for="sponsor in normalSponsors" :key="sponsor.login" class="aside-sponsor" target="_blank" :href="sponsor.rightSidebarLink || sponsor.link">


<div class="aside-sponsors-small">
<a v-for="sponsor in smallSponsors" :key="sponsor.login" class="aside-sponsor" target="_blank" :href="sponsor.rideSidebarLink">
<a v-for="sponsor in smallSponsors" :key="sponsor.login" class="aside-sponsor" target="_blank" :href="sponsor.rightSidebarLink">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the comment above, rightSidebarLink is optional. Consider providing sponsor.link as a fallback to ensure this link is always functional.

        <a v-for="sponsor in smallSponsors" :key="sponsor.login" class="aside-sponsor" target="_blank" :href="sponsor.rightSidebarLink || sponsor.link">

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2026

More templates

@orpc/ai-sdk

npm i https://pkg.pr.new/@orpc/ai-sdk@1477

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@1477

@orpc/client

npm i https://pkg.pr.new/@orpc/client@1477

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@1477

@orpc/experimental-durable-iterator

npm i https://pkg.pr.new/@orpc/experimental-durable-iterator@1477

@orpc/hey-api

npm i https://pkg.pr.new/@orpc/hey-api@1477

@orpc/interop

npm i https://pkg.pr.new/@orpc/interop@1477

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@1477

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@1477

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@1477

@orpc/openapi-client

npm i https://pkg.pr.new/@orpc/openapi-client@1477

@orpc/otel

npm i https://pkg.pr.new/@orpc/otel@1477

@orpc/experimental-pino

npm i https://pkg.pr.new/@orpc/experimental-pino@1477

@orpc/experimental-publisher

npm i https://pkg.pr.new/@orpc/experimental-publisher@1477

@orpc/experimental-publisher-durable-object

npm i https://pkg.pr.new/@orpc/experimental-publisher-durable-object@1477

@orpc/experimental-ratelimit

npm i https://pkg.pr.new/@orpc/experimental-ratelimit@1477

@orpc/react

npm i https://pkg.pr.new/@orpc/react@1477

@orpc/react-query

npm i https://pkg.pr.new/@orpc/react-query@1477

@orpc/experimental-react-swr

npm i https://pkg.pr.new/@orpc/experimental-react-swr@1477

@orpc/server

npm i https://pkg.pr.new/@orpc/server@1477

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@1477

@orpc/solid-query

npm i https://pkg.pr.new/@orpc/solid-query@1477

@orpc/standard-server

npm i https://pkg.pr.new/@orpc/standard-server@1477

@orpc/standard-server-aws-lambda

npm i https://pkg.pr.new/@orpc/standard-server-aws-lambda@1477

@orpc/standard-server-fastify

npm i https://pkg.pr.new/@orpc/standard-server-fastify@1477

@orpc/standard-server-fetch

npm i https://pkg.pr.new/@orpc/standard-server-fetch@1477

@orpc/standard-server-node

npm i https://pkg.pr.new/@orpc/standard-server-node@1477

@orpc/standard-server-peer

npm i https://pkg.pr.new/@orpc/standard-server-peer@1477

@orpc/svelte-query

npm i https://pkg.pr.new/@orpc/svelte-query@1477

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@1477

@orpc/trpc

npm i https://pkg.pr.new/@orpc/trpc@1477

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@1477

@orpc/vue-colada

npm i https://pkg.pr.new/@orpc/vue-colada@1477

@orpc/vue-query

npm i https://pkg.pr.new/@orpc/vue-query@1477

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@1477

commit: 7335467

@dinwwwh dinwwwh merged commit 62c9665 into middleapi:main Mar 16, 2026
3 of 4 checks passed
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation javascript Pull requests that update javascript code size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant