fix randomness for parent block hash in toolkit#878
Open
justinfrevert wants to merge 7 commits intomainfrom
Open
fix randomness for parent block hash in toolkit#878justinfrevert wants to merge 7 commits intomainfrom
justinfrevert wants to merge 7 commits intomainfrom
Conversation
Contributor
|
KICS version: v2.1.19
|
gilescope
reviewed
Mar 7, 2026
|
|
||
| super::make_block_context(timestamp, Default::default(), timestamp) | ||
| let mut parent_hash_bytes = [0u8; 32]; | ||
| rand::rngs::OsRng.fill_bytes(&mut parent_hash_bytes); |
Contributor
There was a problem hiding this comment.
Is there a way for tests that this can be deterministic?
Contributor
There was a problem hiding this comment.
also is there any test coverage for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improve rng used when there is no seed for parent block hash initialization.
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links