Skip to content

[PM-19839] Add support for fallible effects in contract calls#888

Merged
jsidorenko merged 8 commits intomainfrom
js/support-fallible-section-for-contracts
Mar 10, 2026
Merged

[PM-19839] Add support for fallible effects in contract calls#888
jsidorenko merged 8 commits intomainfrom
js/support-fallible-section-for-contracts

Conversation

@jsidorenko
Copy link
Copy Markdown
Contributor

@jsidorenko jsidorenko commented Mar 9, 2026 •
edited
Loading

Overview

Adds support for fallible contract calls

🗹 TODO before merging

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

It was tested locally using the contract from https://shielded.atlassian.net/browse/PM-19863

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Closes https://shielded.atlassian.net/browse/PM-19839

@jsidorenko jsidorenko requested a review from ozgb March 9, 2026 13:19
@jsidorenko jsidorenko requested a review from a team as a code owner March 9, 2026 13:19
@jsidorenko jsidorenko changed the title Add support for fallible effects in contract calls [PM-19839] Add support for fallible effects in contract calls Mar 9, 2026
Base automatically changed from js/toolkit-support-zswap-chaining to main March 9, 2026 18:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026 •
edited
Loading

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 47
LOW LOW 3
INFO INFO 59
TRACE TRACE 0
TOTAL TOTAL 109
Metric Values
Files scanned placeholder 26
Files parsed placeholder 26
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 12

@jsidorenko jsidorenko enabled auto-merge March 10, 2026 11:10
@jsidorenko jsidorenko added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit c580b71 Mar 10, 2026
55 of 56 checks passed
@jsidorenko jsidorenko deleted the js/support-fallible-section-for-contracts branch March 10, 2026 13:31
gilescope pushed a commit that referenced this pull request Apr 8, 2026
@LGLO
feat: serialize MainchainAddress as String, deserialize hexstring and…
5e2084d 
… plain string (#888)
@gilescope gilescope added this to the node-1.0.0 milestone Apr 10, 2026
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
feat: serialize MainchainAddress as String, deserialize hexstring and…
f374399 
… plain string (#888)

Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
feat: serialize MainchainAddress as String, deserialize hexstring and…
eff1f64 
… plain string (#888)

Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ozgb ozgb ozgb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

node-1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jsidorenko @ozgb @gilescope @TheNewAutonomy