macos gsed support

[kaovilai]

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Why the changes were made

❯ OADP_OPERATOR_PATH=../../oadp-operator make update-velero-manifests 
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/go.mod'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_backups.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_backupstoragelocations.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_datadownloads.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_datauploads.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_deletebackuprequests.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_downloadrequests.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_podvolumebackups.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_podvolumerestores.yaml'
sed: 1: "/Users/tiger/git/oadp-n ...": undefined label 'iger/git/oadp-non-admin/hack/extra-crds/velero.io_restores.yaml'
make: *** [update-velero-manifests] Error 1

How to test the changes made

make update-velero-manifests

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mateusoliveira43]

OS_String is used?

[kaovilai]

It was used for codecov in oadp
https://github.com/openshift/oadp-operator/blob/14827fa839dce3ef68dbe63970588dfcf66d1aca/Makefile#L355
No not used here yet. Could be used later.

[kaovilai]

I have converted to the dark side by modifying path. @shubham-pampattiwar lmk if you still want this.

❯ brew info gnu-sed
==> gnu-sed: stable 4.9 (bottled)
....
==> Caveats
GNU "sed" has been installed as "gsed".
If you need to use it as "sed", you can add a "gnubin" directory
to your PATH from your bashrc like:

    PATH="/opt/homebrew/opt/gnu-sed/libexec/gnubin:$PATH"

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kaovilai]

before path change

❯ which sed
/usr/bin/sed

after

❯ which sed
/opt/homebrew/opt/gnu-sed/libexec/gnubin/sed