Skip to content

OADP-7565,OADP-7570,OADP-7573: Go 1.25.8 + x/* dependency bumps#328

Open
kaovilai wants to merge 1 commit intomigtools:oadp-1.5from
kaovilai:oadp-1.5-cve-fix
Open

OADP-7565,OADP-7570,OADP-7573: Go 1.25.8 + x/* dependency bumps#328
kaovilai wants to merge 1 commit intomigtools:oadp-1.5from
kaovilai:oadp-1.5-cve-fix

Conversation

@kaovilai
Copy link
Member

Summary

  • Update Go toolchain from 1.23.6 to 1.25.8 (Go 1.24 is EOL; 1.25 and 1.26 are the supported releases)
  • Bump golang.org/x/* dependencies to latest (x/net v0.52.0, x/sync v0.20.0, x/sys v0.42.0, x/text v0.35.0, x/term v0.41.0)
  • Update Dockerfile to golang:1.25.8 and konflux.Dockerfile to rhel_9_golang_1.25

CVEs Addressed

Go Toolchain (1.25.8)

CVE Component
GO-2026-4337 crypto/tls
GO-2026-4340 crypto/tls
GO-2026-4341 net/url
GO-2026-4342 archive/zip
CVE-2026-25679 net/url (IPv6 host parsing)
CVE-2026-27137 crypto/x509 (email constraints)

golang.org/x/* Dependencies

CVE Component Fix Version
GHSA-vvgc-356p-c3xw golang.org/x/net (XSS in HTML tokenizer) v0.38.0+ (pulled in v0.52.0)

Jira

Test plan

  • go build ./... passes locally
  • CI passes

Note

Responses generated with Claude

Update Go toolchain to 1.25.8 to address:
- GO-2026-4337, GO-2026-4340: crypto/tls
- GO-2026-4341: net/url
- GO-2026-4342: archive/zip
- CVE-2026-25679: net/url IPv6 host parsing
- CVE-2026-27137: crypto/x509 email constraints

Bump golang.org/x/* dependencies:
- x/net v0.52.0 (fixes GHSA-vvgc-356p-c3xw, XSS in HTML tokenizer)
- x/sync v0.20.0, x/sys v0.42.0, x/text v0.35.0, x/term v0.41.0

Update Dockerfile to golang:1.25.8 and konflux.Dockerfile to
rhel_9_golang_1.25.

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Copilot AI review requested due to automatic review settings March 17, 2026 19:38
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 17, 2026

@kaovilai: This pull request references OADP-7565 which is a valid jira issue.

This pull request references OADP-7570 which is a valid jira issue.

This pull request references OADP-7573 which is a valid jira issue.

Details

In response to this:

Summary

  • Update Go toolchain from 1.23.6 to 1.25.8 (Go 1.24 is EOL; 1.25 and 1.26 are the supported releases)
  • Bump golang.org/x/* dependencies to latest (x/net v0.52.0, x/sync v0.20.0, x/sys v0.42.0, x/text v0.35.0, x/term v0.41.0)
  • Update Dockerfile to golang:1.25.8 and konflux.Dockerfile to rhel_9_golang_1.25

CVEs Addressed

Go Toolchain (1.25.8)

CVE Component
GO-2026-4337 crypto/tls
GO-2026-4340 crypto/tls
GO-2026-4341 net/url
GO-2026-4342 archive/zip
CVE-2026-25679 net/url (IPv6 host parsing)
CVE-2026-27137 crypto/x509 (email constraints)

golang.org/x/* Dependencies

CVE Component Fix Version
GHSA-vvgc-356p-c3xw golang.org/x/net (XSS in HTML tokenizer) v0.38.0+ (pulled in v0.52.0)

Jira

Test plan

  • go build ./... passes locally
  • CI passes

[!Note]
Responses generated with Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5004f60d-5652-48e3-a572-d7094c379e53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oadp-snyk
Copy link

oadp-snyk commented Mar 17, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s Go toolchain and container build images to a newer Go release, along with bumping golang.org/x/* module dependencies to pick up security fixes and stay current with supported versions.

Changes:

  • Update go.mod to Go 1.25.x (including toolchain) and bump golang.org/x/* module versions.
  • Refresh go.sum checksums for the updated module versions.
  • Update container build images in Dockerfile and konflux.Dockerfile to Go 1.25-based builders.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
go.mod Moves module go/toolchain to 1.25.x and bumps golang.org/x/* requirements.
go.sum Updates sums to match the new golang.org/x/* module versions.
Dockerfile Switches builder image to golang:1.25.8.
konflux.Dockerfile Switches Konflux builder image to rhel_9_golang_1.25.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

golang.org/x/text v0.35.0 // indirect
golang.org/x/time v0.9.0 // indirect
golang.org/x/tools v0.33.0 // indirect
golang.org/x/tools v0.42.0 // indirect
@mpryc
Copy link
Collaborator

mpryc commented Mar 18, 2026

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants