OADP-7565: Go 1.25.8 + x/* dependency bumps#330
OADP-7565: Go 1.25.8 + x/* dependency bumps#330kaovilai wants to merge 1 commit intomigtools:oadp-devfrom
Conversation
Pin Go toolchain to 1.25.8 to address: - GO-2026-4337, GO-2026-4340: crypto/tls - GO-2026-4341: net/url - GO-2026-4342: archive/zip - CVE-2026-25679: net/url IPv6 host parsing - CVE-2026-27137: crypto/x509 email constraints Bump golang.org/x/* dependencies: - x/net v0.52.0 (fixes GHSA-vvgc-356p-c3xw, XSS in HTML tokenizer) - x/sync v0.20.0, x/sys v0.42.0, x/text v0.35.0, x/term v0.41.0 Update Dockerfile to golang:1.25.8. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
|
@kaovilai: This pull request references OADP-7565 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated Go language runtime version from 1.25 to 1.25.8 in both the Dockerfile and go.mod. Additionally, updated several Go module dependencies including golang.org/x/sync and indirect dependencies for golang.org/x packages (net, sys, term, text, tools). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@kaovilai: This pull request references OADP-7565 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Pull request overview
Updates the project’s Go toolchain and Go module dependencies to incorporate security fixes and stay current with golang.org/x/* releases.
Changes:
- Pin the Go toolchain to
go1.25.8viatoolchaindirective ingo.mod. - Bump
golang.org/x/*dependencies (notablyx/net,x/sync,x/sys,x/text,x/term,x/tools) and refreshgo.sum. - Update the builder image in
Dockerfiletogolang:1.25.8.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Pins toolchain to go1.25.8 and updates golang.org/x/* requirements. |
| go.sum | Updates module checksums to reflect the bumped golang.org/x/* versions. |
| Dockerfile | Uses golang:1.25.8 for the build stage to match the intended toolchain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
golang.org/x/*dependencies to latest (x/net v0.52.0, x/sync v0.20.0, x/sys v0.42.0, x/text v0.35.0, x/term v0.41.0)golang:1.25.8CVEs Addressed
Go Toolchain (1.25.8)
golang.org/x/* Dependencies
Jira
Test plan
go build ./...passes locallyNote
Responses generated with Claude
Summary by CodeRabbit