Added elastic boolean to let the user pan the center view controller past the edge#114
Open
chourobin wants to merge 5 commits intomikefrederick:masterfrom
chourobin:feature/elastic
Open
Added elastic boolean to let the user pan the center view controller past the edge#114chourobin wants to merge 5 commits intomikefrederick:masterfrom chourobin:feature/elastic
chourobin wants to merge 5 commits intomikefrederick:masterfrom
chourobin:feature/elastic
Conversation
Owner
|
I dig it. I would even make this the default behavior (possibly even remove the option). However, right now the library resizes the side menu to fit to inside the leftMenuWidth/rightMenuWidth properties, which makes this behavior odd. There is a black space behind the centerViewController when it is pulled past the menu. Maybe it is better to not adjust the frame of the menus and leave that work up to people using the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to add an elastic effect similar to the Wunderlist 2 iOS app. To keep consistent with existing API, elastic is off by default and needs to be enabled.
Let me know what you think?