fix: enhance headless run functionality with timeout handling#40
Open
fix: enhance headless run functionality with timeout handling#40
Conversation
Added support for handling HeadlessRunTimeoutError in the runHeadless function. Introduced a new utility function to check for this specific error type and updated the execution flow to capture analytics for session and run failures. Improved error logging and ensured proper cleanup after execution.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Added a new utility function to describe various ACP session updates, improving the clarity of logged information. Integrated this functionality into the runHeadless and Executor classes to provide real-time feedback on session activities. Enhanced logging in the AcpClient to capture session creation and prompt dispatch details.
Updated the CLI layers to conditionally use a logger layer based on verbosity settings, improving logging flexibility. Added a new character limit for verbose ACP raw text logging in the run-test utility, ensuring that lengthy messages are truncated for better readability. Enhanced the description of ACP session updates to include raw logging when verbose mode is enabled.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| }) | ||
| .pipe(Effect.catchCause(() => Effect.void)); | ||
| yield* analytics.flush.pipe(Effect.catchCause(() => Effect.void)); | ||
| return yield* error; |
Contributor
There was a problem hiding this comment.
Suggested change
| return yield* error; | |
| return yield* error.asEffect(); |
Missing .asEffect() conversion when re-throwing HeadlessRunTimeoutError in catch handler causes type mismatch in Effect.gen generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for handling HeadlessRunTimeoutError in the runHeadless function. Introduced a new utility function to check for this specific error type and updated the execution flow to capture analytics for session and run failures. Improved error logging and ensured proper cleanup after execution.