Fix stalled run completion and marker handling#61
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
❌ Dogfood Test: failed |
|
❌ Expect tests failed Test output |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
|
✅ Expect tests passed Test output |
|
✅ Expect tests passed Test output |
|
❌ Expect tests failed Test output |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
|
✅ Expect tests passed Test output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STEP_*/RUN_COMPLETEDsurface without leaking into visible outputTesting
Passed
pnpm --filter @expect/shared format -- --checkpnpm --filter @expect/supervisor format -- --checkpnpm --filter @expect/shared test -- dynamic-steps.test.tspnpm --filter @expect/shared test -- prompts.test.tspnpm --filter expect-cli test -- ci-reporter.test.tspnpm --filter @expect/supervisor lintpnpm buildExisting repo/environment blockers
pnpm typecheckfails in@expect/browserbecause generated runtime files are missing (packages/browser/src/generated/runtime-script,runtime-types)pnpm testfails in@expect/cookiesdue to environment-dependent browser/cookie expectations in this containerpnpm --filter @expect/supervisor test -- executor.test.tsalso hits the existing missingpackages/browser/src/generated/runtime-scriptproblem when unrelated watch tests load browser code