fix: skip response.headers.set() in GET handler side-effect check (#206)#211
Open
PranavAgarkar07 wants to merge 1 commit into
Open
fix: skip response.headers.set() in GET handler side-effect check (#206)#211PranavAgarkar07 wants to merge 1 commit into
PranavAgarkar07 wants to merge 1 commit into
Conversation
|
Note No issues found |
|
@PranavAgarkar07 is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a false positive in
nextjsNoSideEffectInGetHandlerwhereresponse.headers.set()was flagged as a side effect in GET route handlers.Setting response headers is a legitimate and expected operation in Next.js GET route handlers — it does not represent a CSRF-vulnerable write. This PR adds an
isHeadersChainCallhelper that excludes.headers.set()(and any.headers.*()mutation) from the DB mutation check infindSideEffect.Closes #206
Note
Low Risk
Low risk: small, localized change to AST side-effect detection logic to reduce false positives, with minimal impact outside GET-handler lint diagnostics.
Overview
Prevents
nextjsNoSideEffectInGetHandler(and other rules usingfindSideEffect) from flaggingresponse.headers.*()calls as “DB mutations” in GET handlers.Adds an
isHeadersChainCallAST helper and uses it to exclude any call whose member chain includes.headersfrom theisMutatingDbCallbranch infindSideEffect, fixing theresponse.headers.set()false positive.Reviewed by Cursor Bugbot for commit cc441af. Bugbot is set up for automated code reviews on this repo. Configure here.