Conversation
added 4 commits
May 5, 2026 19:47
Place all required Configuration constructor params consecutively, with operationsDomain among the optional params at the end.
Switch from nullable String? with conditional toMap to default empty string with unconditional serialization. Native sides treat empty as "not set" (Android skips builder call; iOS converts to nil), mirroring how previousDeviceUUID and previousInstallationId are wired.
Capture init MethodCall args and verify operationsDomain is forwarded across the platform channel both when set and when defaulted.
- Configuration dartdoc: use Dart `null`/empty wording, remove the native-config reference that leaks SDK-internal behavior. - MindboxAndroidPlugin: rename local to operationsDomainArg and apply the builder method outside the chain to avoid name collision with the builder method. - example: drop the placeholder commented-out arg from the sample app.
enotniy
approved these changes
May 6, 2026
| @@ -1,3 +1,7 @@ | |||
| ## Unreleased | |||
|
|
|||
| * Add optional `operationsDomain` parameter to `Configuration` for sending operations to a separate host. Forwarded to the native iOS and Android SDKs. | |||
Collaborator
There was a problem hiding this comment.
А это зачем? Это только в релизной ветке надо делать
Collaborator
Author
There was a problem hiding this comment.
Ага, убрал.
Это по додам выполнилось)
| .subscribeCustomerIfCreated(subscribeIfCreated) | ||
| .shouldCreateCustomer(shouldCreateCustomer) | ||
| .build() | ||
| if (operationsDomainArg.isNotEmpty()) { |
Collaborator
There was a problem hiding this comment.
а зачем тут проверка?
previousDeviceUuid тоже может быть пустым, но все же работает
Collaborator
Author
There was a problem hiding this comment.
Убрал, тут согласен, можно и без этого.
Vailence
force-pushed
the
feature/MOBILE-160
branch
from
7eddbc3 to
5cfafe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOBILE-160: [Flutter] Поддержка анонимайзера для операций sdk