Open
Conversation
enotniy
force-pushed
the
feature/MOBILE-161-operations-domain
branch
from
12b852b to
ba52b81
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for an optional operationsDomain initialization parameter across the React Native JS API and both native bridges, allowing operations to be routed via a dedicated host when configured.
Changes:
- Extended
InitializationDatawith optionaloperationsDomain. - Updated JS initialization payload building to include
operationsDomainonly when it’s a non-empty string. - Passed
operationsDomainthrough to native configuration on both iOS (viaMBConfiguration) and Android (viaMindboxConfiguration.Builder), with unit tests covering presence/absence/empty-string behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/types/InitializationData.ts | Adds optional operationsDomain to the public initialization type. |
| src/index.tsx | Includes operationsDomain in the native init payload only when non-empty; updates inline usage example. |
| src/tests/index.test.ts | Adds unit tests verifying payload behavior for operationsDomain. |
| ios/MindboxSdk.swift | Decodes and forwards operationsDomain into MBConfiguration. |
| android/src/main/java/com/mindboxsdk/MindboxSdkModule.kt | Forwards operationsDomain into MindboxConfiguration.Builder when present in the payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
82
to
86
| * shouldCreateCustomer: true, | ||
| * previousInstallId: '', | ||
| * previousUuid: '', | ||
| * operationsDomain: 'anonymizer.example.com', | ||
| * }); |
Vailence
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-161