Skip to content

Remove: machine_accounts feature flag. #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mujib-Ahasan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove: machine_accounts feature flag. #5971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controlplane/handlers_authz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ func (s *Server) AssignRole(ctx context.Context, req *minder.AssignRoleRequest)
if !isMachine && flags.Bool(ctx, s.featureFlags, flags.UserManagement) {
return nil, util.UserVisibleError(codes.Unimplemented, "human users may only be added by invitation")
}
if isMachine && !flags.Bool(ctx, s.featureFlags, flags.MachineAccounts) {
if isMachine {
Copy link
Member

@evankanderson evankanderson Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, this is tricky, since this is a negative use of the flag -- in this case, I think flags.Bool(ctx, s.featureFlags, flags.MachineAccounts) should effectively always return true, so if isMachine && !true will always evaluate to false, and the entire if false {...} block can be removed.

return nil, util.UserVisibleError(codes.Unimplemented, "machine accounts are not enabled")
}
assignment, err := db.WithTransaction(s.store, func(qtx db.ExtendQuerier) (*minder.RoleAssignment, error) {
Expand Down
2 changes: 0 additions & 2 deletions pkg/flags/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ const (
DockerHubProvider Experiment = "dockerhub_provider"
// GitLabProvider enables the GitLab provider.
GitLabProvider Experiment = "gitlab_provider"
// MachineAccounts enables machine accounts (in particular, GitHub Actions) for authorization
MachineAccounts Experiment = "machine_accounts"
// AlternateMessageDriver enables an an alternate message driver.
AlternateMessageDriver Experiment = "alternate_message_driver"
// GitPRDiffs enables the git ingester for pull requests.
Expand Down
Loading