fix(scripts): default remote GPU helpers to index 5 (#33)#229
Open
RealDiligent wants to merge 1 commit into
Open
fix(scripts): default remote GPU helpers to index 5 (#33)#229RealDiligent wants to merge 1 commit into
RealDiligent wants to merge 1 commit into
Conversation
Align setup_remote, run_remote, and remote_env fallbacks with DEFAULT_TRINITY_GPU_INDEX so unset TRINITY_GPU_INDEX no longer pins jobs to GPU 0. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Resubmit of #33 after the infra auto-close bug was fixed on main. CI green + MERGEABLE. Ready for review/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33 (resubmits closed #137/#141/#146 after the infra auto-close bug was fixed on main).
Remote helper scripts defaulted
TRINITY_GPU_INDEXto0when unset, while validator config andsecrets.env.examplestandardize on GPU 5.This PR changes the shell fallbacks to
:-5insetup_remote.sh,run_remote.sh, andremote_env.sh, and adds a regression test.Test plan
test_setup_remote_defaults_to_gpu_five_when_unsetMiniRouter / submissionstays pending (infra PR, not a miner submission)