Added right-to-left layout exporting capability#927
Added right-to-left layout exporting capability#927michelebastione merged 2 commits intomini-software:masterfrom
Conversation
Added parameter RightToLeft to OpenXmlConfiguration that enables exported worksheets to be read in a right-to-left layout by Excel.
Summary of ChangesHello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Excel export functionality by adding support for right-to-left worksheet layouts. A new configuration option allows users to specify if the exported sheet should be displayed from right to left, which is crucial for languages that read in that direction. This change ensures that the generated OpenXML correctly reflects the desired text directionality in Excel. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new capability to export worksheets with a right-to-left layout, which is a valuable addition. The implementation is straightforward, adding a new configuration property and using it to generate the appropriate OpenXML attribute. However, I found a critical typo in the name of the new public property RighToLeft which should be corrected to RightToLeft. Additionally, no tests have been added to verify this new functionality. Please add unit or integration tests to ensure the feature works as expected and to prevent future regressions.
Closes #340 by adding the parameter
RightToLefttoOpenXmlConfigurationthat enables exported worksheets to be read in a right-to-left layout by Excel.