Skip to content

Added right-to-left layout exporting capability#927

Merged
michelebastione merged 2 commits intomini-software:masterfrom
michelebastione:right-to-left
Feb 25, 2026
Merged

Added right-to-left layout exporting capability#927
michelebastione merged 2 commits intomini-software:masterfrom
michelebastione:right-to-left

Conversation

@michelebastione
Copy link
Contributor

@michelebastione michelebastione commented Feb 25, 2026

Closes #340 by adding the parameter RightToLeft to OpenXmlConfiguration that enables exported worksheets to be read in a right-to-left layout by Excel.

Added parameter RightToLeft to OpenXmlConfiguration that enables exported worksheets to be read in a right-to-left layout by Excel.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @michelebastione, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Excel export functionality by adding support for right-to-left worksheet layouts. A new configuration option allows users to specify if the exported sheet should be displayed from right to left, which is crucial for languages that read in that direction. This change ensures that the generated OpenXML correctly reflects the desired text directionality in Excel.

Highlights

  • Right-to-Left Layout Export: Introduced a new RighToLeft boolean property in OpenXmlConfiguration to control the right-to-left layout for exported Excel worksheets.
  • XML Generation Update: Modified the StartSheetView method in WorksheetXml to accept a rightToLeft parameter, which is then used to generate the corresponding XML attribute.
  • Configuration Integration: Integrated the new RighToLeft configuration property into the GetSheetViews method within OpenXmlWriter.DefaultOpenXml to apply the right-to-left setting during worksheet generation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/MiniExcel.OpenXml/Constants/WorksheetXml.cs
    • Modified StartSheetView method to accept a rightToLeft boolean parameter.
  • src/MiniExcel.OpenXml/OpenXmlConfiguration.cs
    • Added RighToLeft boolean property with a default value of false.
  • src/MiniExcel.OpenXml/OpenXmlWriter.DefaultOpenXml.cs
    • Updated GetSheetViews method to utilize the new RighToLeft configuration property when generating the sheet view XML.
    • Adjusted the early exit condition in GetSheetViews to also consider the RighToLeft property.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new capability to export worksheets with a right-to-left layout, which is a valuable addition. The implementation is straightforward, adding a new configuration property and using it to generate the appropriate OpenXML attribute. However, I found a critical typo in the name of the new public property RighToLeft which should be corrected to RightToLeft. Additionally, no tests have been added to verify this new functionality. Please add unit or integration tests to ensure the feature works as expected and to prevent future regressions.

@michelebastione michelebastione merged commit 6bc13a7 into mini-software:master Feb 25, 2026
3 checks passed
@michelebastione michelebastione deleted the right-to-left branch February 25, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right to left document excel

1 participant