327 adds docker compose setup w postgres#328
327 adds docker compose setup w postgres#328willbuck wants to merge 2 commits intominnestar:mainfrom
Conversation
…als, adds X qualifier to twitter, marks all optional
|
Can attest that this worked beautifully. Just had to run |
| @@ -0,0 +1,34 @@ | |||
| version: '3.9' | |||
There was a problem hiding this comment.
I'm pretty sure "version" is obsolete and can be removed. Additionally, the new idiom is to call this file compose.yaml. Would you mind making that change?
|
|
||
| services: | ||
| db: | ||
| image: postgres:15 |
There was a problem hiding this comment.
Is there a reason for 15 rather than 16 or 17?
|
Can you remove 27bec45 from this PR and make it just docker compose? |
|
As long as somebody’s actually using the feature, seems like a good idea. This PR also seems to include a commit from the social media feature? May need a rebase + force push. |
|
@pcantrell @willbuck what should we do with this PR? Close it, or do we actually want to include a Docker option in the repo? My gut says the app is still so small that running it natively is just fine. If the setup were more involved Docker would make more sense, but it would also muddy the setup instructions (do you run it native, or with docker?) |
5 participants
Closes #327