Fix for Useless assignment to local variable #809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, to fix this kind of issue you either (a) remove the redundant initial assignment, or (b) collapse the declaration and first real assignment together so that the variable is declared without an unused default. This keeps the code’s behavior identical while eliminating dead stores.
Here,
parsedis always assigned inside theif/else; we can safely remove the= NaNinitializer and keep justlet parsed;. JavaScriptletdeclarations without initialization are legal, and both branches of theif/elseguarantee thatparsedreceives a value before the subsequentNumber.isNaN(parsed)check. No other code changes or imports are needed, and no external behavior changes.Concretely, in
runtime/src/decoders.js, change line 155 fromlet parsed = NaN;tolet parsed;. All other lines remain unchanged.Suggested fixes powered by Copilot Autofix. Review carefully before merging.