Draft
Conversation
…quest` and `process_send_request_and_sign` from `wallet::Account`, use `select_inputs_for_send_request` directly instead
…hat use a frozen token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another bunch of minor improvements extracted from my other branch:
Chainstate order tests didn't check order operations (except creation) with frozen tokens, so I added a separate test for that.
common/src/primitives/error.rscontained an unused error typeMintlayerErrorso I removed it.The phrase "hex encoded" was replaced with "hex-encoded" everywhere.
In
test/functional/wallet_multisig_address.pythe call tocli_check_orders_with_filterswas erroneously omitted, so I added it back. Also, freeze_order/conclude_order calls in the test were not checking whether the corresponding tx has been submitted successfully or not, this is also fixed.In
wallet/src/account/mod.rsI removed the methodsprocess_send_requestandprocess_send_request_and_signand their callers are now callingselect_inputs_for_send_requestdirectly. The reason for the removal is that they were not only redundant, but also inappropriately named, because e.g.process_send_request_and_signdidn't sign anything.Renamed some existing types in
wallet/wallet-cli-commands/src/helper_types.rs, so that they all have the "Cli" prefix and introduced more "Cli" types, which are now used in WalletCommand instead of plain strings. Also added more tests.