Merged
Conversation
…verflow on Windows when the db reaches 2GB.
…-pemfile`. Some other crates had to be updated as well (cherry-picked from master)
…ntained); appease clippy 1.92 (cherry-picked from master)
OBorce
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hotfix release to address the LMDB failure on Windows when the db reaches 2GB.
The cause of the issue is that our (pretty ancient) version of LMDB uses the
off_ttype to represent positions inside the file andoff_tappears to be 32-bit on Windows, so when the db grows to 2 GB, it overflows.The fix is the change of the revision of
lmdb-rs-mintlayerinstorage/lmdb/Cargo.toml(There are a few other commits with changes cherry-picked from master, needed to appease CI.)P.S. in the
lmdb-rs-mintlayerrepo, the fix is in the commit 88d9f2bd49399f75ca1baa1537b2387252f9b5db (which is basically a copy of an upstream commit).Also, the diff between
v0.16.2and88d9f2bd49399f75ca1baa1537b2387252f9b5dbincludes one extra commit, which contains changes cherry-picked fromlmdb-rs-mintlayer's master with various CI fixes.Note: I won't be creating a separate PR in the
lmdb-rs-mintlayerrepo specifically for the v1.2.1 release, so plz review those changes as part of this PR.