-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add responsive auto layout modes to Columns #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brandonmcconnell
wants to merge
5
commits into
main
Choose a base branch
from
brandon/update-card-to-include-layout-prop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−9
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7bdfd5c
feat: add responsive auto layout modes to Columns
brandonmcconnell d5b176f
refactor: use media query breakpoints for standard column responsiveness
brandonmcconnell 1a1554f
style: format constant imports for readability
brandonmcconnell ea8fa93
docs: refactor Columns layout stories for side-by-side comparison
brandonmcconnell 8cae626
fix: remove max-width constraint from Columns component
brandonmcconnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,30 @@ | ||
| const COL_OPTIONS = [1, 2, 3, 4] as const; | ||
| type ColCount = (typeof COL_OPTIONS)[number]; | ||
|
|
||
| export { COL_OPTIONS }; | ||
| const DEFAULT_COLS = 2; | ||
| const DEFAULT_MIN_COL_WIDTH = "200px"; | ||
| const DEFAULT_AUTO_MODE = "static"; | ||
|
|
||
| const COL_CLASSES: Record<number, string> = { | ||
| 1: "sm:grid-cols-1", | ||
| 2: "sm:grid-cols-2", | ||
| 3: "sm:grid-cols-3", | ||
| 4: "sm:grid-cols-4", | ||
| }; | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const AUTO_MODES = { | ||
| static: undefined, | ||
| fill: "auto-fill", | ||
| fit: "auto-fit", | ||
| } as const; | ||
|
|
||
| export { | ||
| COL_OPTIONS, | ||
| COL_CLASSES, | ||
| AUTO_MODES, | ||
| DEFAULT_COLS, | ||
| DEFAULT_MIN_COL_WIDTH, | ||
| DEFAULT_AUTO_MODE, | ||
| }; | ||
|
|
||
| export type { ColCount }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type cast incorrectly excludes
"static"layout valueLow Severity
The cast
layout as "fit" | "fill"omits"static", but theObject.entriesloop iterates over all three keys including"static". Whenlayoutis"static", this is a type lie — it narrows the type to a union that doesn't include the actual runtime value. The cast needs to belayout as "static" | "fit" | "fill"(orlayout as ColumnsProps["layout"]) to match the iterated keys.