Skip to content

fix: サーバー全体のアップロードサイズ上限とロールポリシーのアップロードサイズ上限に関する修正#17389

Merged
syuilo merged 4 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-17331
Jun 3, 2026
Merged

fix: サーバー全体のアップロードサイズ上限とロールポリシーのアップロードサイズ上限に関する修正#17389
syuilo merged 4 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-17331

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 11, 2026

What

  • ロールポリシーで解決される maxFileSizeMb では config.maxFileSize が上限となるように
  • ロールポリシー設定画面に全体ファイルサイズに関する説明を追加
image

Why

#17331

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 11, 2026
@github-actions github-actions Bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.93%. Comparing base (23bb992) to head (4127e17).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17389      +/-   ##
===========================================
+ Coverage    15.21%   24.93%   +9.72%     
===========================================
  Files          247     1160     +913     
  Lines        12358    39573   +27215     
  Branches      4194    11019    +6825     
===========================================
+ Hits          1880     9869    +7989     
- Misses        8203    23802   +15599     
- Partials      2275     5902    +3627     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 301.30 MB 305.79 MB +4.48 MB +1.48%
VmHWM 301.30 MB 305.79 MB +4.48 MB +1.48%
VmSize 23078.20 MB 23083.02 MB +4.81 MB +0.02%
VmData 1344.74 MB 1349.27 MB +4.52 MB +0.33%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 301.33 MB 305.80 MB +4.46 MB +1.48%
VmHWM 301.33 MB 305.80 MB +4.46 MB +1.48%
VmSize 23078.29 MB 23083.27 MB +4.98 MB +0.02%
VmData 1344.82 MB 1349.52 MB +4.69 MB +0.34%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 301.65 MB 306.33 MB +4.67 MB +1.55%
VmHWM 301.65 MB 306.33 MB +4.67 MB +1.55%
VmSize 23078.29 MB 23083.52 MB +5.23 MB +0.02%
VmData 1344.82 MB 1349.77 MB +4.94 MB +0.36%

See workflow logs for details

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit e50603e into misskey-dev:develop Jun 3, 2026
37 of 40 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 Jun 3, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Jun 3, 2026

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-17331 branch June 3, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants