Skip to content

revert(backend): revert compile-config#17411

Open
kakkokari-gtyih wants to merge 8 commits into
misskey-dev:developfrom
kakkokari-gtyih:revert-compile-config
Open

revert(backend): revert compile-config#17411
kakkokari-gtyih wants to merge 8 commits into
misskey-dev:developfrom
kakkokari-gtyih:revert-compile-config

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 15, 2026

What

Why

Fix #17407
Fix #17075

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 22.41%. Comparing base (e50603e) to head (d21faae).

Files with missing lines Patch % Lines
packages/backend/src/config.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17411      +/-   ##
===========================================
- Coverage    24.93%   22.41%   -2.53%     
===========================================
  Files         1158     1160       +2     
  Lines        39539    39572      +33     
  Branches     11011    11020       +9     
===========================================
- Hits          9858     8869     -989     
- Misses       23780    24662     +882     
- Partials      5901     6041     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 297.85 MB 307.92 MB +10.07 MB +3.38%
VmHWM 297.85 MB 307.92 MB +10.07 MB +3.38%
VmSize 23163.29 MB 23173.11 MB +9.81 MB +0.04%
VmData 1363.51 MB 1373.22 MB +9.71 MB +0.71%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 298.02 MB 307.92 MB +9.89 MB +3.31%
VmHWM 298.02 MB 307.92 MB +9.89 MB +3.31%
VmSize 23163.46 MB 23173.11 MB +9.65 MB +0.04%
VmData 1363.67 MB 1373.22 MB +9.54 MB +0.70%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 298.46 MB 308.31 MB +9.85 MB +3.30%
VmHWM 298.46 MB 308.31 MB +9.85 MB +3.30%
VmSize 23163.54 MB 23173.11 MB +9.56 MB +0.04%
VmData 1363.76 MB 1373.22 MB +9.46 MB +0.69%

See workflow logs for details

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review May 15, 2026 08:44
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 15, 2026
@anatawa12 anatawa12 linked an issue May 15, 2026 that may be closed by this pull request
1 task
@anatawa12
Copy link
Copy Markdown
Member

17075 リンクしました

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

👀

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

compile-config の廃止提案 Add environment variable for JSON config

2 participants