enhance(frontend): MkDraggable をタッチ操作 (ドラッグ) に対応 (PointerEvents版)#17535
Open
fruitriin wants to merge 3 commits into
Open
enhance(frontend): MkDraggable をタッチ操作 (ドラッグ) に対応 (PointerEvents版)#17535fruitriin wants to merge 3 commits into
fruitriin wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17535 +/- ##
===========================================
- Coverage 24.93% 15.04% -9.90%
===========================================
Files 1158 247 -911
Lines 39539 12512 -27027
Branches 11011 4244 -6767
===========================================
- Hits 9858 1882 -7976
+ Misses 23780 8308 -15472
+ Partials 5901 2322 -3579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ドロップハンドラが group 不一致で no-op になった際にも source 側で 削除が走っていたため、別 group の MkDraggable に誤ってドロップすると item が消失していた。handler の戻り値を boolean 化し、target 側で 処理が成立した場合のみ source から削除するよう修正。 合わせて onPointerDown 内の重複コメントを 1 行に短縮し、 page-editor.el.note.vue 内の不要な空行 (削除済み eslint-disable の跡) を整理した。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MkDraggable の Pointer Events 化に合わせて、ドラッグハンドルを持つ呼び出し 側 (RolesEditorFormula / server-rules / channel-editor / navbar / profile / page-editor 各種) を dragStart/dragStartCallback から pointerStart/ pointerStartCallback に切り替え、ハンドル要素に touch-action: none を付与。 不要となった drag-and-drop.ts の MkDraggable DragDataMap エントリも削除。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
46bb45c to
7413bc9
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
スマートフォン等のタッチデバイスで MkDraggable による並び替えができるようにする。
PointerEventsに統一する
また、MkPagesで挙動不審になるので、この画面のコンテキストメニューのあしらいを変更する
Why
Fix #17515
Fix #17487
Additional info (optional)
Checklist