feature: add padding side to allow pad from left#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable padding side for batch processing
Problem
The batch processor only supported right padding, which works for encoder-decoder models but causes issues with decoder-only models (like GPT) that require left padding to maintain proper attention patterns.
Solution
Added a
padding_sideparameter throughout the inference pipeline to control where padding tokens are added when batching sequences of different lengths.Changes
stack_features()to support left/right paddingpadding_sideparameter toModelBatchProcessorand@dynamicallydecoratorpadding_sideparameter toAsyncModelBatchProcessorand async@dynamicallydecoratorUsage
Backward Compatibility
Example
Fixes issues with decoder-only model batching while maintaining full backward compatibility.