Skip to content

chore/add external id#254

Merged
joeldierkes merged 6 commits into
mainfrom
chore/add-external-id
Nov 4, 2025
Merged

chore/add external id#254
joeldierkes merged 6 commits into
mainfrom
chore/add-external-id

Conversation

@joeldierkes
Copy link
Copy Markdown
Contributor

@joeldierkes joeldierkes commented Nov 4, 2025

  • feat(api): update via SDK Studio

  • feat(api): api update

  • codegen metadata

  • chore(internal): grammar fix (it's -> its)

  • chore: add the external id and parsing strategy


Note

Extends store file operations to accept external_id with new config/overwrite options and updates polling to use a unified file_identifier, plus minor docs/metadata tweaks.

  • Stores API (files):
    • poll() now takes file_identifier (ID or external_id) and updates internal calls accordingly in both sync/async resources.
    • Add config, external_id, and overwrite parameters to create_and_poll(), upload(), and upload_and_poll() (sync and async), plumbed through to create.
    • Expanded method docstrings with Args/Returns.
  • Misc:
    • Grammar fix in _utils.py comment ("it's" → "its").
    • Update .stats.yml config_hash.

Written by Cursor Bugbot for commit 31187b0. This will update automatically on new commits. Configure here.

*,
store_identifier: str,
metadata: Optional[object] | NotGiven = not_given,
config: file_create_params.Config | Omit = omit,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Type Mismatch: Metadata Omission in Create Flow

Type inconsistency for metadata parameter in create_and_poll method. The create() method expects metadata: object | Omit = omit, but create_and_poll() declares it as metadata: Optional[object] | NotGiven = not_given. When create_and_poll passes metadata to create(), there's a type mismatch between NotGiven and Omit, which could cause the metadata to not be properly omitted from the request.

Fix in Cursor Fix in Web

*,
store_identifier: str,
metadata: Optional[object] | NotGiven = not_given,
config: file_create_params.Config | Omit = omit,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Async metadata type mismatch in poller method

Type inconsistency for metadata parameter in async create_and_poll method. The async create() method expects metadata: object | Omit = omit, but async create_and_poll() declares it as metadata: Optional[object] | NotGiven = not_given. When create_and_poll passes metadata to create(), there's a type mismatch between NotGiven and Omit, which could cause the metadata to not be properly omitted from the request.

Fix in Cursor Fix in Web

@joeldierkes joeldierkes merged commit fb8ef47 into main Nov 4, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant