Add upn fallback for single-tenant Microsoft/Azure AD authentication#295
Open
lperezmo wants to merge 1 commit intomkhorasani:mainfrom
Open
Add upn fallback for single-tenant Microsoft/Azure AD authentication#295lperezmo wants to merge 1 commit intomkhorasani:mainfrom
lperezmo wants to merge 1 commit intomkhorasani:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Azure AD tokens for single-tenant (work/school) configurations often omit the
emailclaim but includeupn(User Principal Name), which is typically the user's email address. This causes authentication to fail because downstream code expectsemailto be present. This affects anyone using Microsoft OAuth with a single-tenant app registration to restrict login to their organization.Fix
Falls back to
upnwhenemailis absent in the decoded JWT. The change is minimal (3 lines) and fully backwards compatible - multi-tenant setups that already returnemailare unaffected, andupnis preserved in the dict for anyone relying on it.Context
I've been monkey-patching this method in production for about a year to get single-tenant SSO working for my organization. Figured it was worth upstreaming since it's a small, safe change and this is probably a common pain point for anyone using single-tenant app registrations.