fix: align S[...] notation with address formula in Tile Layout section#141
fix: align S[...] notation with address formula in Tile Layout section#141xush6528 wants to merge 1 commit into
Conversation
The dimension names were listed as (tile_row, row_in_tile, tile_col, col_in_tile) but the address formula below computes in the order (tile_row, tile_col, row_in_tile, col_in_tile) with strides (16, 8, 4, 1). Updated S[(4, 2, 2, 4) : (16, 4, 8, 1)] to S[(4, 2, 2, 4) : (16, 8, 4, 1)] and reordered the dimension names to match.
There was a problem hiding this comment.
Code Review
This pull request corrects the coordinate order and corresponding strides for a 4-D layout representing tiled matrices in the documentation. Specifically, it changes the coordinate order from (tile_row, row_in_tile, tile_col, col_in_tile) to (tile_row, tile_col, row_in_tile, col_in_tile) and updates the strides accordingly to ensure the tiles remain contiguous. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
You should make the change here as well. |
|
@xush6528 @rock42069 Thanks so much for catching this, we really appreciate it! The intended convention follows the default tiling rule(like For a 2D matrix tiled by 2x4, this gives: So the layout should remain: The issue is that the address demo currently displays the terms in a different order, which makes it look as if the layout were using: Thanks again for pointing this out! We’ll fix it in the upcoming Chinese-version PR for the layout chapter. |
The dimension names were listed as (tile_row, row_in_tile, tile_col, col_in_tile) but the address formula below computes in the order (tile_row, tile_col, row_in_tile, col_in_tile) with strides (16, 8, 4, 1).
Updated S[(4, 2, 2, 4) : (16, 4, 8, 1)] to S[(4, 2, 2, 4) : (16, 8, 4, 1)] and reordered the dimension names to match.