Merged
Conversation
benoit-cty
approved these changes
Feb 6, 2026
Contributor
benoit-cty
left a comment
There was a problem hiding this comment.
Thank you very much !
We plan to improve Windows support next month, that's a great help.
ad7a57e to
7bbe9b2
Compare
added 2 commits
February 8, 2026 19:24
… check to work on Windows as well
7bbe9b2 to
489afe5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 68.26% 68.51% +0.25%
==========================================
Files 41 41
Lines 3847 3862 +15
==========================================
+ Hits 2626 2646 +20
+ Misses 1221 1216 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 3 commits
February 8, 2026 19:31
Contributor
|
To manually test on Windows:
|
- Add test for is_psutil_available() with small nice value - Add comprehensive error handling tests for count_physical_cpus() on Windows: - CalledProcessError - TimeoutExpired - ValueError for invalid output This brings test coverage to 100% for the Windows-specific code paths added in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For Windows hosts function is_psutils_available() fails.
utils function get_physical_cpu_count() delivers not the number of sockets, but the number of logical cores.
Related Issue
n.a.
Motivation and Context
On Windows host the energy consumption did fall back to a constant estimation (not taking CPU load into account). The reason for this is the is_psutils_available() function not working on Windows, although psutils is functioning on Windows.
The number of physical CPU problem showed up after solving is_psutils_available(). The reported numbers were not plausible.
How Has This Been Tested?
Unit tests are added. Before that manual tests on Windows host was performed.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.