fix: broken logo on PyPI (absolute raw URL) + bump to 1.5.2 - #129
Merged
Conversation
Bump across pyproject, __init__, and server.json, with a changelog entry. The README logo fix (absolute raw-GitHub URL) only reaches the PyPI page on a new release, since PyPI freezes the README at publish time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header logo shows as a broken image on the PyPI package page.
Cause: the README used a repo-relative image src (
public/logo.png). GitHub resolves relative paths against the repo, but PyPI renders the README standalone with no access to repo files, so the image 404s there.Fix: point the logo at the absolute raw-GitHub URL (
https://raw.githubusercontent.com/mldsveda/PyScrappy/main/public/logo.png, verified 200), the same way the Glama badge just below it already uses an absolute URL. Renders on both GitHub and PyPI.Bump to 1.5.2: PyPI freezes the README at publish time, so the fix only reaches the package page on a new release. Version bumped across
pyproject.toml,__init__.py, andserver.json, with a changelog entry.