Fix missing CSS attr defaults - #133
Merged
vedaant00 merged 1 commit intoAug 10, 2026
Merged
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SelectorList’s CSS ::attr(...) handling to align with Scrapy/Parsel-style semantics: elements that match the selector but lack the requested attribute no longer yield an empty-string value, allowing .get(default=...) to return the default and .getall() to exclude missing attributes.
Changes:
- Update
SelectorList._values()for::attr(...)to skip elements where the attribute key is absent. - Add regression tests covering
.get(default)for missing attributes and.getall()behavior when some elements lack the attribute.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/pyscrappy/generic/selector.py |
Adjusts ::attr(...) value extraction to skip elements missing the attribute, enabling correct .get(default) semantics. |
tests/test_generic/test_selector.py |
Adds targeted tests for missing-attribute defaults and getall() skipping behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::attr(...)values skip elements where the requested attribute is absent..get(default)return the provided default for matched elements that lack the attribute.getall().Fixes #131.
Tests
python -m pytest tests/test_generic/test_selector.py::TestCss::test_css_attr_missing_attribute_uses_default tests/test_generic/test_selector.py::TestCss::test_css_attr_getall_skips_missing_attributes -qfailed with'' == 'MISSING'and['/present', ''] == ['/present']python -m pytest tests/test_generic/test_selector.py -q→21 passedpython -m pytest tests/ -q→471 passed, 1 skipped, 19 deselectedruff check src/→All checks passed!