Document SoundCloud async JS limitation - #134
Merged
Merged
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
Collaborator
|
Thanks @kocaemre, merged. This is exactly the resolution #130 called for: the docstring no longer claims parity it does not have, it names render_js/scroll_pages as sync-only, and points async users at the right method. Nice touch adding a regression test that asserts both the honest wording is present and the old "same args/returns" phrasing is gone, so it cannot silently creep back. Appreciate the clean contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SoundCloudScraper.scrape_async.render_js/scroll_pages.Verification
python -m pytest tests/test_scrapers/test_music.py::TestSoundCloudScraper::test_async_docstring_documents_http_only_limitation -qfailed because the docstring still claimed parity.python -m pytest tests/test_scrapers/test_music.py::TestSoundCloudScraper -qpython -m pytest tests/ -qruff check src/ tests/Fixes #130.