Skip to content

NULL terminate empty and malformed inputs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cybojanek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NULL terminate empty and malformed inputs #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mini-printf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ mini_vsnprintf(char *buffer, unsigned int buffer_len, const char *fmt, va_list v
b.pbuffer = buffer;
b.buffer_len = buffer_len;

if (buffer_len > 0) {
*buffer = 0;
}

while ((ch=*(fmt++))) {
if ((unsigned int)((b.pbuffer - b.buffer) + 1) >= b.buffer_len)
break;
Expand Down
12 changes: 12 additions & 0 deletions test1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,17 @@ int main(void)
puts(buff);
mini_snprintf(buff, sizeof buff, "%d %u %d %u", 50, 50, -50, -50);
puts(buff);
mini_snprintf(buff, sizeof buff, "%0");
puts(buff);
mini_snprintf(buff, sizeof buff, "a%0");
puts(buff);
mini_snprintf(buff, sizeof buff, "%");
puts(buff);
mini_snprintf(buff, sizeof buff, "b%");
puts(buff);
mini_snprintf(buff, 0, "%s", "hello");
puts(buff);
mini_snprintf(buff, sizeof buff, "");
puts(buff);
return 0;
}
6 changes: 6 additions & 0 deletions test1.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ faster and "cheaper"
deadf00d % DEADF00D
00000000100000000200000000300
50 50 -50 4294967246

a

b
b