Open
Conversation
mazen-kasser
approved these changes
Oct 25, 2016
mazen-kasser
left a comment
mazen-kasser
left a comment
There was a problem hiding this comment.
Good job, just run swiftlint to adjust the spacing and indention.
| } | ||
| /// The strings to be shown on as suggestions, setting the value of this automatically reload the tableview | ||
| public var autoCompleteStrings:[String]?{ | ||
| open var autoCompleteStrings:[String]?{ |
There was a problem hiding this comment.
missing space open var autoCompleteStrings:[String]? {
| self.clearButtonMode = .Always | ||
| self.addTarget(self, action: "textFieldDidChange", forControlEvents: .EditingChanged) | ||
| self.addTarget(self, action: "textFieldDidEndEditing", forControlEvents: .EditingDidEnd) | ||
| autoCompleteAttributes = [NSForegroundColorAttributeName:UIColor.black] |
There was a problem hiding this comment.
I guess no need to mentioned UIColor just .black
| cell?.textLabel?.font = autoCompleteTextFont | ||
| cell?.textLabel?.textColor = autoCompleteTextColor | ||
| cell?.textLabel?.text = autoCompleteStrings![indexPath.row] | ||
| cell?.textLabel?.text = autoCompleteStrings![(indexPath as NSIndexPath).row] |
There was a problem hiding this comment.
please update if on swift 3. How I can i Download from pull request?
There was a problem hiding this comment.
Yes I have converted in swift 3 and implemented in my code
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.