-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ENH: Add optional channel name overlay to plot_alignment #13570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ENH: Add optional channel name overlay to plot_alignment #13570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take a look at other files in this directory, to see how they should be formatted (e.g. no heading, and mention the author and PR number)
mne/viz/_3d.py
Outdated
| xyz[0], | ||
| xyz[1], | ||
| xyz[2], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| xyz[0], | |
| xyz[1], | |
| xyz[2], | |
| *xyz, |
|
@aman-coder03 please also look at our tutorials or examples that use |
|
thanks for your suggestion @drammock |
What does this PR do?
adds an optional
show_channel_namesparameter toplot_alignmentto overlay channel labels at sensor locations in the 3D alignment view.Why?
this improves interpretability when inspecting sensor alignment, especially for debugging, teaching, and demonstrations. The feature is fully opt-in and does not change default behavior.
Backward compatibility
fully backward compatible (disabled by default).
Tests
visualization tests pass (dataset-dependent tests skipped as expected).
fixes #13502